Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix APARENT/site_probabilities output labels #285

Merged
merged 2 commits into from Jan 3, 2022
Merged

Fix APARENT/site_probabilities output labels #285

merged 2 commits into from Jan 3, 2022

Conversation

twrightsman
Copy link
Contributor

From the APARENT paper methods section on the cleavage model:

The 186 first Softmax probabilities are trained to predict the cleavage proportions of the 186 nucleotides in the input sequence. The 187-th probability predicts the remaining proportion of polyadenylation outside the sequence window (i.e., the distal isoform).

The model used by Kipoi is an updated one with 205bp but should be the same in terms of output arrangement.

I'm not sure if the tests also have to be updated, but I don't know how to do that.

@haimasree
Copy link
Contributor

Hello! Thanks for the update and it seems tests are fine as well.
@Hoeze I am merging this pr. Let me know if you disagree.

@haimasree haimasree merged commit f2b45c8 into kipoi:master Jan 3, 2022
@Hoeze
Copy link
Member

Hoeze commented Jan 19, 2022

Hi @twrightsman, thanks a lot for your pull request, you're absolutely right!
It's really cool that you found + fixed that mistake 😀

The same issue also affects the variant effect prediction.
Also, I'm investigating how to best handle the isoform window there.
PR will follow :)


Sorry for my late answer, I did not have time to investigate your PR earlier 😶

bytewife pushed a commit that referenced this pull request Feb 1, 2024
Fix APARENT/site_probabilities output labels
bytewife pushed a commit that referenced this pull request Feb 1, 2024
Fix APARENT/site_probabilities output labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants