Skip to content

Commit

Permalink
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel…
Browse files Browse the repository at this point in the history
…/git/ieee1394/linux1394-2.6

* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6:
  firewire: fw-ohci: plug dma memory leak in AR handler
  • Loading branch information
torvalds committed Apr 1, 2008
2 parents 1002747 + 6b84236 commit 670e23c
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions drivers/firewire/fw-ohci.c
Expand Up @@ -401,7 +401,8 @@ static void ar_context_tasklet(unsigned long data)

if (d->res_count == 0) {
size_t size, rest, offset;
dma_addr_t buffer_bus;
dma_addr_t start_bus;
void *start;

/*
* This descriptor is finished and we may have a
Expand All @@ -410,9 +411,9 @@ static void ar_context_tasklet(unsigned long data)
*/

offset = offsetof(struct ar_buffer, data);
buffer_bus = le32_to_cpu(ab->descriptor.data_address) - offset;
start = buffer = ab;
start_bus = le32_to_cpu(ab->descriptor.data_address) - offset;

buffer = ab;
ab = ab->next;
d = &ab->descriptor;
size = buffer + PAGE_SIZE - ctx->pointer;
Expand All @@ -427,7 +428,7 @@ static void ar_context_tasklet(unsigned long data)
buffer = handle_ar_packet(ctx, buffer);

dma_free_coherent(ohci->card.device, PAGE_SIZE,
buffer, buffer_bus);
start, start_bus);
ar_context_add_page(ctx);
} else {
buffer = ctx->pointer;
Expand Down

0 comments on commit 670e23c

Please sign in to comment.