Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some email addresses are not recognized #80

Closed
steebchen opened this issue Jun 29, 2015 · 3 comments
Closed

Some email addresses are not recognized #80

steebchen opened this issue Jun 29, 2015 · 3 comments

Comments

@steebchen
Copy link

Some emails are not recognized:
foo@foo-bar.com // works
foo@foo-bar.de // doesn't work

Seems that your regex ca|co\.uk|com|edu|net|org is a bit spare. It would be great if you either add domains like .de or edit the regex for all top level domains (I can't help you there - I hate regexes).

Here is a list of most TLDs: https://de.wikipedia.org/wiki/Top-Level-Domain

@steebchen steebchen changed the title Email addresses are not recognized Some email addresses are not recognized Jun 29, 2015
@kirbysayshi
Copy link
Owner

Thanks for the bug report. I've been hesitant to include every tld since email address parsing is already so error prone. But I'll look again, maybe it's not too bad now.

In the meantime, a workaround for you is to either use an explicit expression: @("foo@foo-bar.de") or manually escape the @: foo@@foo-bar.de

kirbysayshi added a commit that referenced this issue Jun 30, 2015
Probably an ok compromise vs including all country tlds.
@kirbysayshi
Copy link
Owner

@steebchen Two letters should be included as email addresses now! Hope this helps. v0.9.2

@steebchen
Copy link
Author

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants