Fix test_importers.py #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'Fix' might be exaggerating a bit. It passes the test.
cydanil
approved these changes
Jun 22, 2020
|
No problem! From what I can see, importers try to parse recipes from various different file formats and websites so they can be added to Gourmet's database. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #28
This is separated out from #116. It doesn't actually fix the importer tests in CI (trying to solve that revealed much bigger issues, which led to separating this out), but running just those tests in isolation succeeds:
I think these changes are an improvement by themselves, even if they don't fix the tests in CI.