Fix timer

[eginhard]

Description

These changes fix various warnings and errors that occurred when using the timer and prevented it from ringing.

How Has This Been Tested?

I confirmed that the warnings disappeared and the timer can now ring, using both gstreamer or pyglet if that is available.

There is a threading issue when using pyglet and closing Gourmet after the timer has gone off, but I don't know how to solve that for now.

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[cydanil]

Thanks for taking the time to work on this!
I think that you can mitigate the threading issue with the following:

Class Player:
    def __init__(self):
        Gst.init()
        self.player = Gst.ElementFactory.make('playbin', 'player')
        self.player.connect('about-to-finish', self.stop_play)

     def stop_play(self):
           self.player.set_state(Gst.State.NULL)

Would you mind testing that?

Also, could you clean the imports such that it's

from gi.repository import Gst

and add to gourmet/__init__.py

require_version("Gst", "1.0")

[cydanil]

Suggested change

	def stop_play(self,path):
	def stop_play(self):

[eginhard]

I removed the stop_play methods as they are not used.

[eginhard]

Thanks, I made those changes. With sound_gst.py (when pyglet is not available) there are no issues, it's from sound_pyglet.py. After pyglet has played the timer (the sound also seems cut off compared to gst) and I want to close Gourmet, a dialog with "Another process is in progress - Exit program anyway?" appears and selecting "Quit" logs the following:

DEBUG: gourmet/gourmet/GourmetRecipeManager.py: 466 Unable to terminate thread <GLibMainLoopThread(Thread-1, started daemon 140028434503424)>

Are all the different ways to play sound actually necessary (there's also sound_windows.py) or is there something that works well across platforms?

[cydanil]

I think only Gst should be used: the historical reason for having different players was that back in the days, sound handling was not that well integrated between user applications and the OS.

Indeed, you could remove the other sound handlers.

[eginhard]

Great, that simplified things.

[cydanil]

Cracking, thanks a lot!