Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getServerSideProps() is not unit tested #326

Closed
tkrotoff opened this issue Mar 2, 2021 · 1 comment
Closed

getServerSideProps() is not unit tested #326

tkrotoff opened this issue Mar 2, 2021 · 1 comment

Comments

@tkrotoff
Copy link

tkrotoff commented Mar 2, 2021

https://github.com/kirill-konshin/next-redux-wrapper/blob/types-enchancements/packages/wrapper/tests/server.spec.tsx#L22-L32

The unit test is named test('getServerSideProps', ... but it calls getStaticProps() instead of getServerSideProps().
@kirill-konshin
Copy link
Owner

Thanks, fixed

kirill-konshin added a commit that referenced this issue Mar 4, 2021
@kirill-konshin
Fix #326
fff9c4e
kirill-konshin added a commit that referenced this issue Apr 17, 2021
@kirill-konshin @melanieseltzer @DanielOrtel
Types enchancements (#295)
e2255c2 
* Fix #280
* Fix #207
* Minor fixes
* Updated API
* Updated versions
* Update README.md
* Fixed demos & tests
* Github Action
* Make demo-dynamic private
* Fix #326
* Fix hot reloading issues by removing the store from window (#324)

Co-authored-by: Melanie Seltzer <melleh11@gmail.com>
Co-authored-by: Daniel Ferenc Balogh <danielferencortel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tkrotoff @kirill-konshin