Types enchancements #295
Merged
Types enchancements #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 29, 2020
|
Very interested in this change, as I think it may potentially fix the featureRequest I just posted. @kirill-konshin. Overall, the solution looks pretty good, though it does expose an API and a frame of execution that can be... quite verbose. |
Co-authored-by: Melanie Seltzer <melleh11@gmail.com>
kirill-konshin
force-pushed
the
types-enchancements
branch
13 times, most recently
from
f364875
to
e006a0d
Compare
kirill-konshin
force-pushed
the
types-enchancements
branch
4 times, most recently
from
b77d4da
to
0c2ebd6
Compare
kirill-konshin
force-pushed
the
types-enchancements
branch
from
0c2ebd6
to
6c48b2c
Compare
|
@melanieseltzer @richterk @Jekins @khaibula @GVanderLugt https://github.com/kirill-konshin/next-redux-wrapper/releases/tag/7.0.0-rc.1 please help me to test this in the wild. Make sure you follow the updated API. |
kirill-konshin
force-pushed
the
types-enchancements
branch
from
219b38a
to
193e2a3
Compare
nikichv
reviewed
Feb 16, 2021
README.md
Outdated
| export type AppThunk<ReturnType = void> = ThunkAction<ReturnType, AppState, unknown, Action>; | ||
| ``` | ||
|
|
||
| As you see in this example `` |
There was a problem hiding this comment.
Looks like something was lost here )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #280
Fix #207
Fix #240
Fix #226
Fix #293
Based on #247