Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use path/filepath to join the cache path. #2

Merged
merged 2 commits into from
Sep 29, 2017
Merged

use path/filepath to join the cache path. #2

merged 2 commits into from
Sep 29, 2017

Conversation

schlubbi
Copy link
Contributor

@schlubbi schlubbi commented Sep 28, 2017

This will use the path separator that's native to the OS. Partially addressing #1
There seem to be more errors related to the caching.

@codecov-io
Copy link

codecov-io commented Sep 28, 2017

Codecov Report

Merging #2 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #2   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files          16       16           
  Lines         288      288           
=======================================
  Hits          284      284           
  Misses          2        2           
  Partials        2        2
Impacted Files Coverage Δ
cache/cache.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab0dc8d...f312089. Read the comment docs.

@schlubbi schlubbi closed this Sep 28, 2017
@schlubbi schlubbi reopened this Sep 28, 2017
@kirillrogovoy
Copy link
Owner

@schlubbi, thank you very much for finding time to look into this issue!

I've also found another place where I should've been used filepath.Join as well and fixed that.

I'm also attaching godoc links here for everyone interested:

@kirillrogovoy kirillrogovoy merged commit fe1fbb9 into kirillrogovoy:master Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants