feat: bridgeless support #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirillzyusko
added
enhancement
kirillzyusko
force-pushed
the
chore/react-native-0.74
branch
from
d9141cc
to
0ae9b68
Compare
📊 Package size report
|
kirillzyusko
force-pushed
the
chore/react-native-0.74
branch
from
0ae9b68
to
d5eee8b
Compare
2 tasks
kirillzyusko
added a commit
that referenced
this pull request
Jun 15, 2024
… 0.72 (#475) ## 📜 Description Fixed compilation errors on RN 0.71 and `keyboard-controller` 1.12. ## 💡 Motivation and Context `emitDeviceEvent` is available only in RN 0.72 and we don't want to support RN 0.72 as the minimal version (because it's still quite new):  The original change was introduced in #410 - it was needed because old implementation threw errors (crashes) in bridgeless mode on Fabric. In this Pr I made it compatible with bridgeless + it doesn't use newly introduced methods, so it should have a support until RN 0.65 again. ## 📢 Changelog <!-- High level overview of important changes --> <!-- For example: fixed status bar manipulation; added new types declarations; --> <!-- If your changes don't affect one of platform/language below - then remove this platform/language --> ### Android - don't use `emitDeviceEvent` as it's available only in RN 0.72; - revert to previous code variant, but send an event from `ReactApplicationContext` class instance; ## 🤔 How Has This Been Tested? Tested on Pixel 7 Pro (Android 14), Fabric + RN 0.74 ## 📝 Checklist - [x] CI successfully passed - [x] I added new mocks and corresponding unit-tests if library API was changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Updated
react-nativeto0.74(wich has bridgeless mode enabled by default in new arch).💡 Motivation and Context
We need to support bridgeless mode.
Main changes to make fabric working were:
_jsThreadon iOS (since it's bridgeless mode -> these variable will be alwaysfalse);Also in this PR I had to remove flipper integration to speed up delivery of this PR. Later on I'll probably add this integration back.
Closes #429 #394
📢 Changelog
JS
iOS
_jsThreadcheck as in Fabric it'll be alwaysfalse;Android
🤔 How Has This Been Tested?
tested locally + on CI using both architectures.
📸 Screenshots (if appropriate):
Everything works as before 🙃
📝 Checklist