Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin iOS/XCode versions to a local env #472

Merged
merged 4 commits into from
Jun 13, 2024

Conversation

kirillzyusko
Copy link
Owner

@kirillzyusko kirillzyusko commented Jun 13, 2024

📜 Description

Pinned iOS to 17.5 and XCode to latest stable 15.4 for all iOS jobs.

💡 Motivation and Context

Recently GH updated images and now iOS e2e tests are running on iOS 18. iOS 18 is incompatible with current Detox (typeText crashes the app).

So in this PR I decided to lock everything to the same versions that I'm using locally (i. e. XCode 15.4 and iOS 17.5).

📢 Changelog

E2E

  • pin iOS simulator to iOS 17.5 to pass job on CI.

CI

  • pin XCode version to 15.4;

🤔 How Has This Been Tested?

Verified that CI is green.

📸 Screenshots (if appropriate):

image

📝 Checklist

  • CI successfully passed
  • I added new mocks and corresponding unit-tests if library API was changed

@kirillzyusko kirillzyusko added 🍎 iOS iOS specific CI CI (github actions) e2e Anything about E2E tests labels Jun 13, 2024
@kirillzyusko kirillzyusko self-assigned this Jun 13, 2024
Copy link
Contributor

github-actions bot commented Jun 13, 2024

📊 Package size report

Current size Target Size Difference
144033 bytes 144033 bytes 0 bytes 📉

@kirillzyusko kirillzyusko marked this pull request as ready for review June 13, 2024 16:22
@kirillzyusko kirillzyusko merged commit 8a575c1 into main Jun 13, 2024
13 checks passed
@kirillzyusko kirillzyusko deleted the chore/identical-setup-to-local-env branch June 13, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI (github actions) e2e Anything about E2E tests 🍎 iOS iOS specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant