chore(*): fix typos && simplify some test code (#245)

* chore(*): fix typos && simplify some test code

* chore(typo): fix typo

errcheck/embedded_walker_test.go

@@ -35,12 +35,12 @@ type testCase struct {
 
 func TestWalkThroughEmbeddedInterfaces(t *testing.T) {
 	cases := []testCase{
-		testCase{"Inner{}.Method", false, nil},
-		testCase{"(&Inner{}).Method", false, nil},
-		testCase{"Outer{}.Method", false, nil},
-		testCase{"InnerInterface.Method", true, []string{"test.InnerInterface"}},
-		testCase{"OuterInterface.Method", true, []string{"test.OuterInterface", "test.InnerInterface"}},
-		testCase{"OuterInterfaceStruct.Method", true, []string{"test.OuterInterface", "test.InnerInterface"}},
+		{"Inner{}.Method", false, nil},
+		{"(&Inner{}).Method", false, nil},
+		{"Outer{}.Method", false, nil},
+		{"InnerInterface.Method", true, []string{"test.InnerInterface"}},
+		{"OuterInterface.Method", true, []string{"test.OuterInterface", "test.InnerInterface"}},
+		{"OuterInterfaceStruct.Method", true, []string{"test.OuterInterface", "test.InnerInterface"}},
 	}
 
 	for _, c := range cases {

errcheck/errcheck.go

@@ -80,7 +80,7 @@ func (r *Result) Append(other Result) {
 	r.UncheckedErrors = append(r.UncheckedErrors, other.UncheckedErrors...)
 }
 
-// Returns the unique errors that have been accumulated. Duplicates may occur
+// Unique returns the unique errors that have been accumulated. Duplicates may occur
 // when a file containing an unchecked error belongs to > 1 package.
 //
 // The method receiver remains unmodified after the call to Unique.
@@ -338,7 +338,7 @@ func (v *visitor) selectorName(call *ast.CallExpr) string {
 // then just that function's fullName is returned.
 //
 // Otherwise, we walk through all the potentially embedded interfaces of the receiver
-// the collect a list of type-qualified function names that we will check.
+// to collect a list of type-qualified function names that we will check.
 func (v *visitor) namesForExcludeCheck(call *ast.CallExpr) []string {
 	sel, fn, ok := v.selectorAndFunc(call)
 	if !ok {
@@ -351,7 +351,7 @@ func (v *visitor) namesForExcludeCheck(call *ast.CallExpr) []string {
 	}
 
 	// This will be missing for functions without a receiver (like fmt.Printf),
-	// so just fall back to the the function's fullName in that case.
+	// so just fall back to the function's fullName in that case.
 	selection, ok := v.typesInfo.Selections[sel]
 	if !ok {
 		return []string{name}
@@ -420,9 +420,9 @@ func (v *visitor) ignoreCall(call *ast.CallExpr) bool {
 	//     2. x.y.f()
 	var id *ast.Ident
 	switch exp := call.Fun.(type) {
-	case (*ast.Ident):
+	case *ast.Ident:
 		id = exp
-	case (*ast.SelectorExpr):
+	case *ast.SelectorExpr:
 		id = exp.Sel
 	default:
 		// eg: *ast.SliceExpr, *ast.IndexExpr

main_test.go

@@ -13,7 +13,7 @@ import (
 
 var dotStar = regexp.MustCompile(".*")
 
-func TestMain(t *testing.T) {
+func TestMainFunc(t *testing.T) {
 	saveStderr := os.Stderr
 	saveStdout := os.Stdout
 	saveCwd, err := os.Getwd()