Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error:failed to check package: could not type check #1

Closed
gwenn opened this issue Feb 25, 2013 · 2 comments
Closed

Error:failed to check package: could not type check #1

gwenn opened this issue Feb 25, 2013 · 2 comments

Comments

@gwenn
Copy link

gwenn commented Feb 25, 2013

Hello,
First, many thanks for your tool.
And, just for feedback, I've got some errors while checking some packages (building successfully):
$ errcheck github.com/gwenn/gosqlite
error:failed to check package: could not type check: /home/gwen/Projects/src/github.com/gwenn/gosqlite/cache.go:35:35: undeclared name: Stmt

$ errcheck github.com/gwenn/csvdiff
error:failed to check package: could not type check: /home/gwen/Projects/src/github.com/gwenn/csvdiff/csvdiff.go:274:20: cannot assign hasher (variable of type hash.Hash64) to variable of type Hasher

Regards.

@kisielk
Copy link
Owner

kisielk commented Feb 25, 2013

Thanks for the feedback. The errors are coming from the go/types library. It's still not quite complete so doesn't handle all code just yet. In particular it seems that code using cgo, so such as gosqlite will fail. I think we just have to wait for that library to mature a little further, it's still under active development.

@kisielk
Copy link
Owner

kisielk commented Mar 1, 2013

Fixed by Go revision f10ff2e7c9bd

@kisielk kisielk closed this as completed Mar 1, 2013
@ghost ghost mentioned this issue Apr 17, 2013
kisielk pushed a commit that referenced this issue Oct 1, 2014
echlebek pushed a commit that referenced this issue Oct 23, 2020
Simplify vendored package resolution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants