Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot handle packages which contains asm file #170

Closed
bobotu opened this issue Sep 2, 2019 · 2 comments
Closed

Cannot handle packages which contains asm file #170

bobotu opened this issue Sep 2, 2019 · 2 comments

Comments

@bobotu
Copy link

bobotu commented Sep 2, 2019

Errcheck returns error when processing packge contains an empty asm file

error: failed to check packages: errors while loading package memdb: [memdb.s:12:35: expected ';', found 'EOF' memdb.s:12:35: expected 'IDENT', found 'EOF' memdb.s:12:35: expected 'package', found 'EOF' -: package ; expected memdb]

It seems like a bug in golang's tools,
I have tried to use the latest version of golang.org/x/tools and this error goes away.
This was referenced Sep 16, 2019
Closed
Closed
@echlebek
Copy link
Collaborator

We've upgraded the golang.org/x/tools dependency. Can you test with v1.3.0 and see if the issue resolves?

@echlebek
Copy link
Collaborator

echlebek commented Aug 4, 2020

Assuming this works now, please re-open if you find it's still a problem.

@echlebek echlebek closed this as completed Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use the latest version of the golang.org/x/tools ekalinin/errcheck
2 participants
@echlebek @bobotu