Clarify supported Python versions #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 89.31% (diff: 100%)@@ master #205 diff @@
==========================================
Files 4 5 +1
Lines 595 730 +135
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 525 652 +127
- Misses 70 78 +8
Partials 0 0
|
kislyuk
reviewed
Jan 27, 2017
| @@ -15,6 +15,8 @@ the network). | |||
|
|
|||
| Installation | |||
| ------------ | |||
| Argcomplete requires Python 2.7 or 3.3+. | |||
There was a problem hiding this comment.
Please move this to the bottom of the readme, next to the Common Problems section.
Space at the top of the readme is precious and we shouldn't clutter it with warnings about python versions that roughly nobody uses.
There was a problem hiding this comment.
I moved it under its own heading, but I don't know if it looks weird because the section is so short.
I also removed another bit of 2.6-specific code and updated the RTD link.
|
Merging - if you don't like the way the readme turned out, let me know and I'll change it. |
|
LGTM, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.