Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the deprecated call to datetime.utcnow() with datetime.now(tz.utc) #196

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

iyuepan
Copy link
Contributor

@iyuepan iyuepan commented Mar 10, 2024

This PR removes uses of the function datatime.utcnow() in the function _get_stream_name which is deprecated since python 3.12, and replaces it with datetime.now(timezone.utc).

Note that this causes a breaking change in a way that the default logged date time will now include the UTC timezone (e.g., 2024-03-10 04:05:38.888377 to 2024-03-10 04:05:38.888377+00:00), which is actually preferred to avoid confusions.

@kislyuk kislyuk merged commit f8e498e into kislyuk:develop Mar 10, 2024
2 of 12 checks passed
@kislyuk
Copy link
Owner

kislyuk commented Mar 10, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants