Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the test suite (or rather, the code) for Python 3 #35

Merged
merged 1 commit into from
Feb 10, 2017

Conversation

asergi
Copy link
Collaborator

@asergi asergi commented Feb 10, 2017

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 10, 2017

Codecov Report

Merging #35 into master will decrease coverage by -0.17%.

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
- Coverage   85.83%   85.66%   -0.17%     
==========================================
  Files          15       15              
  Lines        1221     1221              
==========================================
- Hits         1048     1046       -2     
- Misses        173      175       +2
Impacted Files Coverage Δ
pcapfile/protocols/network/ip.py 79.12% <ø> (ø)
pcapfile/test/protocols_transport_tcp.py 90% <100%> (ø)
pcapfile/protocols/linklayer/wifi.py 86.08% <100%> (-0.35%)
pcapfile/protocols/transport/tcp.py 71.79% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f156e5...1b0bf06. Read the comment docs.

@kisom kisom merged commit 6852469 into kisom:master Feb 10, 2017
@asergi asergi deleted the tests-py3 branch February 11, 2017 10:16
@asergi
Copy link
Collaborator Author

asergi commented Feb 11, 2017

Unfortunately, 69d970a breaks Python 3 again 😞

@asergi
Copy link
Collaborator Author

asergi commented Feb 15, 2017

Fixed in 106b33f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants