Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttplug Integration with Yiffspot #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Buttplug Integration with Yiffspot #51

wants to merge 1 commit into from

Conversation

qdot
Copy link
Contributor

@qdot qdot commented Aug 17, 2018

This PR contains all of the code for basic Buttplug (https://github.com/metafetish/buttplug-js) integration with Yiffspot. The first 6 commits are project preparation, with the final commit (f881310) containing all of the integration code.

All patch code has been manually tested, though probably not well.

Possible issues:

  • The Buttplug panel on the sidebar takes up a surprising amount of room, and I'm not sure how many people are actually going to use this. Still wondering if this should maybe ship collapsed by default, with a click event to uncollapse it?
  • This balloons the project to something like 4.5x its current size. On initial network transfer with caching disabled, current yiffspot sends ~208kb. This patch expands that to ~948kb due to dependencies. May be worth looking into gzip'ing before things hit the line on the express side. :(
  • We only support vibrating devices for the moment, and the UI isn't real clear about that.
  • There's a good chance we may opaquely drop some errors. I tried to test everything but manual QA is hard. :)

PR build is up and running at https://teledildonic-yiffspot.glitch.me/ if you want to test the patch without rolling your own server.

Fixes #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant