Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network hands-on #8

Merged
merged 6 commits into from
Nov 15, 2021
Merged

Add network hands-on #8

merged 6 commits into from
Nov 15, 2021

Conversation

tomo0037
Copy link
Contributor

変更点

ネットワークのハンズオンの資料を追加

  • ./md/intro_network2_1.mdの追加
  • ./md/intro_network2_2.mdの追加
  • ./pdf/intro_network2_2.pdfの追加
  • ./imgの追加(画像を入れる場所)

確認ポイント

  • ネットワークハンズオン1回目でやったことが思い出せる内容になっている.
  • ネットワークハンズオン2回目でやったことが思い出せる内容になっている.
  • ファイルの参照ができている
  • 誤字脱字がない
  • LGTM

Copy link
Contributor

@silmin silmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ちょいちょい入ってる横線 <hr> と改行 <br> がほんとに必要か気になります(別にこれはどうでもいいけどちょい読みにくそう)

README.md Outdated Show resolved Hide resolved
md/intro_network2_1.md Outdated Show resolved Hide resolved
@tomo0037 tomo0037 requested a review from silmin November 15, 2021 04:34
md/intro_network2_1.md Outdated Show resolved Hide resolved
@silmin
Copy link
Contributor

silmin commented Nov 15, 2021

良さそうなのでMergeします!

@silmin silmin merged commit 836b80c into main Nov 15, 2021
@silmin silmin deleted the handson branch November 15, 2021 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants