-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly resolve query-fn #53
Conversation
Yeah, it's a just a bit of extra magic. :) |
Would have been nice if Integrant somehow did this automatically but that's the price we pay for the system definition just being a map I guess. |
yup |
@yogthos Actually, in practice the modification times could be stored as a defonced atom the kit.edge.db.sql.conman namespace instead of inside the component instance. This would preclude running several instances of a system including that component in the same REPL session, but is that goal for Kit? I have actually never seen an example of that in docs or examples I think, but would be nice for stuff like bringing up an additional system with a test profile when running tests from the REPL. Is that suppose to work? |
I'd rather not put hidden state in component libraries. It would provide a bit of convenience, but I don't think it's worth it overall. In general, I'd like to keep Kit as unopinionated as possible, and I can definitely see uses for having multiple systems for things like tests. |
@yogthos I agree, which is obviously why I coded the patch as such. I do find the testing page a bit light on details. Perhaps a section on such a use case could be described? |
oh yeah, what if we just use metadata instead of sticking it into a map? |
and yeah testing page could definitely be fleshed out more :) |
ok, switched to use |
Very sweet indeed! |
Yeah it's probably worth mentioning, this is seems like the exact use case metadata is meant for. |
Created issue
weavejester/integrant#106
tors 18 jan. 2024 kl. 12:48 skrev Dmitri Sotnikov ***@***.***
…:
Yeah it's probably worth mentioning, this is seems like the exact use case
metadata is meant for.
—
Reply to this email directly, view it on GitHub
<#53 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAADU5Q4MC3CWPYJO7MUISLYPEDZZAVCNFSM6AAAAABB5BDPKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJYGMZDSNZWHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
DItto.
I don't like this extra complexity in the beginners tutorial but it is what it is.