Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to spring boot3 #194

Merged

Conversation

VolkerHartmann
Copy link
Collaborator

@VolkerHartmann VolkerHartmann commented May 26, 2023

  • Bump SpringBoot to version 3
  • Fix tests.
  • Bump service-base to version 1.2.0
  • Update README.md
    • Requirements: JDK 17+
  • Update CHANGELOG.md


implementation "edu.kit.datamanager:service-base:1.1.1"
implementation "edu.kit.datamanager:service-base:1.2.0-SNAPSHOT"

implementation "com.github.java-json-tools:json-patch:1.13"
implementation "com.github.dozermapper:dozer-core:6.5.2"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

24% of developers fix this issue

Medium Vulnerability:

maven : com.github.dozermapper/dozer-core : 6.5.2

0 Critical, 0 High, 1 Medium, 0 Low vulnerabilities have been found across 1 dependencies.
View the Lift console for details about these vulnerabilities.


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

@@ -179,7 +179,7 @@ public String getValue() {
private String language;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6% of developers fix this issue

UnnecessarilyFullyQualified: This fully qualified name is unambiguous to the compiler if imported.


Suggested change
private String language;
SuppressWarnings

❗❗ 48 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding
File Path Line Number
src/main/java/edu/kit/datamanager/repo/domain/GeoLocation.java 48
src/main/java/edu/kit/datamanager/repo/domain/DataResource.java 182
src/main/java/edu/kit/datamanager/repo/domain/Subject.java 47
src/main/java/edu/kit/datamanager/repo/domain/DataResource.java 184
src/main/java/edu/kit/datamanager/repo/domain/RelatedIdentifier.java 126
src/main/java/edu/kit/datamanager/repo/domain/DataResource.java 106
src/main/java/edu/kit/datamanager/repo/domain/DataResource.java 143
src/main/java/edu/kit/datamanager/repo/domain/Contributor.java 86
src/main/java/edu/kit/datamanager/repo/domain/Contributor.java 88
src/main/java/edu/kit/datamanager/repo/domain/Subject.java 51

Showing 10 of 48 findings. Visit the Lift Web Console to see all.


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

@sonatype-lift
Copy link

sonatype-lift bot commented Jun 19, 2023

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/kit-data-manager/repo-core/194.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/kit-data-manager/repo-core/194.diff | git apply

Once you're satisfied, commit and push your changes in your project.

Footnotes

  1. You can preview the patch by opening the patch URL in the browser.

@VolkerHartmann VolkerHartmann merged commit 626f611 into kit-data-manager:development Jun 19, 2023
1 check was pending
@VolkerHartmann VolkerHartmann deleted the bumpToSpringBoot3 branch June 27, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant