This repository has been archived by the owner on Feb 13, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustHumanz
changed the title
Metrics for custom threat rules #232
Metrics for custom threat rules
Jun 19, 2022
dwisiswant0
suggested changes
Jun 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is neat, @JustHumanz! Before that, I have some concerns such as code-style, workable improvisation, and expression implementation questions below.
dwisiswant0
added
Type: Enhancement
New feature or request
Status: Revision Needed
A round of revision is needed before this work may be published
Status: Available
Priority: Medium
labels
Jun 21, 2022
dwisiswant0
reviewed
Jun 24, 2022
dwisiswant0
approved these changes
Jun 25, 2022
All good now! Thanks for your contributions, @JustHumanz. |
@all-contributors add @JustHumanz for accessibility. |
I've put up a pull request to add @JustHumanz! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Priority: Medium
Status: Available
Status: Revision Needed
A round of revision is needed before this work may be published
Type: Enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add metrics for custom threat rules #232
Proposed of changes
This PR fixes/implements the following bugs/features:
How has this been tested?
Proof:
Checklist: