Skip to content
This repository has been archived by the owner on Feb 13, 2024. It is now read-only.

Metrics for custom threat rules #233

Merged
merged 8 commits into from
Jun 25, 2022
Merged

Metrics for custom threat rules #233

merged 8 commits into from
Jun 25, 2022

Conversation

JustHumanz
Copy link
Contributor

@JustHumanz JustHumanz commented Jun 19, 2022

Summary

Add metrics for custom threat rules #232

Proposed of changes

This PR fixes/implements the following bugs/features:

How has this been tested?

Proof:

Screenshot from 2022-06-19 00-06-30

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have followed the guidelines in our CONTRIBUTING.md document.
  • I have written new tests for my changes.
    • My changes successfully ran and pass tests locally.

@JustHumanz JustHumanz changed the title Metrics for custom threat rules #232 Metrics for custom threat rules Jun 19, 2022
Copy link
Member

@dwisiswant0 dwisiswant0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is neat, @JustHumanz! Before that, I have some concerns such as code-style, workable improvisation, and expression implementation questions below.

CHANGELOG.md Outdated Show resolved Hide resolved
pkg/metrics/prometheus.go Outdated Show resolved Hide resolved
pkg/metrics/prometheus.go Outdated Show resolved Hide resolved
pkg/metrics/prometheus.go Outdated Show resolved Hide resolved
pkg/metrics/prometheus.go Outdated Show resolved Hide resolved
@dwisiswant0 dwisiswant0 added Type: Enhancement New feature or request Status: Revision Needed A round of revision is needed before this work may be published Status: Available Priority: Medium labels Jun 21, 2022
@dwisiswant0
Copy link
Member

All good now! Thanks for your contributions, @JustHumanz.

@dwisiswant0 dwisiswant0 merged commit 63ddb15 into kitabisa:v2 Jun 25, 2022
@dwisiswant0
Copy link
Member

@all-contributors add @JustHumanz for accessibility.

@allcontributors
Copy link
Contributor

@dwisiswant0

I've put up a pull request to add @JustHumanz! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Priority: Medium Status: Available Status: Revision Needed A round of revision is needed before this work may be published Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] metrics for custom threat rules
2 participants