Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove plan object and all conditions relying on it #187

Merged
merged 5 commits into from
Jan 8, 2019
Merged

Remove plan object and all conditions relying on it #187

merged 5 commits into from
Jan 8, 2019

Conversation

abe33
Copy link
Contributor

@abe33 abe33 commented Dec 12, 2018

Closes #185

@abe33 abe33 requested a review from jansorg December 13, 2018 12:14
jansorg
jansorg suggested changes Dec 13, 2018
View reviewed changes
Copy link
Contributor

@jansorg jansorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abe33 Thanks!

  • I'm still seeing "Kite Basic" next to the logo
  • Move Help link to 3rd instead of 5th
  • Rename Kite Search -> Search Python Docs
  • Rename Settings -> Package settings (see the spec if Package isn't fitting for VSCode)
  • Change label and link of Permissions to macth Kite Engine Settings

Apologies if some of this wasn't clear in the issue!

@jansorg
Copy link
Contributor

jansorg commented Dec 14, 2018 •
edited
Loading

@abe33

  • I'm still seeing "Kite Basic" next to the logo. Remove "Kite Basic"
  • Move Help link to 3rd instead of 5th

@jansorg
Copy link
Contributor

jansorg commented Dec 18, 2018 •
edited by abe33
Loading

@abe33

  • Help is 2nd, but should be 3rd in the list of links. See https://kite.quip.com/rVcJA1bIqZny/Kite-Status-Spec#QcWACAO7aGZ for a mockup
  • I'm not seeing Package settings here. I'm unsure if this was the case before. If the extension has a sort of settings ui then please add a menu item to open it. See the mockup linked above for details

@abe33
Copy link
Contributor Author

abe33 commented Dec 18, 2018

As for the Package Settings we can't do anything because VSCode don't allow us to do that.

@jansorg
Copy link
Contributor

jansorg commented Jan 7, 2019

@abe33 could we merge this?

@abe33 abe33 merged commit f628483 into master Jan 8, 2019
@abe33 abe33 deleted the cn-remove-plan branch January 8, 2019 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansorg jansorg jansorg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abe33 @jansorg