Make usage of absolute links configurable #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stweil
reviewed
Apr 23, 2020
Co-Authored-By: Stefan Weil <sw@weilnetz.de>
albig
previously approved these changes
Apr 24, 2020
There was a problem hiding this comment.
Actually this seems to work but keep in mind:
With TYPO9.5:
- You need a site-configuration with a base including scheme+domain. Without this the links keep to be relative. Providing "/" as base will change nothing with these settings and won't make absolute URLs.
- If you have no HTTPS scheme provided in the site-configuration, it won't be force by this setting.
- Don't know, what is happening with TYPO3 8.7.
As it shouldn't break anything, we can merge this even if it won't work as expected in all situaltions.
|
That's how it is intended to work:
But you are right, I should make it clearer, that having a proper |
albig
approved these changes
Apr 24, 2020
albig
reviewed
Apr 27, 2020
| } | ||
| return $content; | ||
| $conf['parameter'] = $altPageId ?: ($this->pi_tmpPageId ?: 'current'); | ||
| $conf['additionalParams'] = $this->conf['parent.']['addParams'] . HttpUtility::buildQueryString($urlParameters, '&', true) . $this->pi_moreParams; |
There was a problem hiding this comment.
buildQueryString() is unknown in TYPO3 8.7.
There was a problem hiding this comment.
Good catch! I'll fix it in a separate pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In multi-domain environments like the Zeitungsportal we need the option to force all links to be absolute. Since TYPO3 9.x the Typoscript configuration option
config.absRefPrefixonly effects links generated by Typoscript, but doesn't work globally.This Pull-Request introduces new extension-wide configuration options to force all generated links to be absolute. In addition it allows using HTTPS as default scheme for those URLs.
The default is to not use absolute links, so existing instances should behave exactly like before.