Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include fallback for TYPO3 8.7 #510

Merged
merged 4 commits into from Apr 27, 2020

Conversation

sebastian-meyer
Copy link
Member

I've added a fallback solution for TYPO3 8.7, since AbstractPlugin::pi_linkTP() looks quite different there compared to TYPO3 9+. This should fix the issue mentioned in #506.

@sebastian-meyer sebastian-meyer added the 🐛 bug A non-security related bug. label Apr 27, 2020
@sebastian-meyer sebastian-meyer self-assigned this Apr 27, 2020
Copy link
Collaborator

@albig albig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the typo for urlParameter, this is working on my TYPO3 8.7 setup.

Classes/Common/AbstractPlugin.php Show resolved Hide resolved
Classes/Common/AbstractPlugin.php Show resolved Hide resolved
Classes/Common/AbstractPlugin.php Outdated Show resolved Hide resolved
@sebastian-meyer sebastian-meyer merged commit a34b620 into kitodo:master Apr 27, 2020
@sebastian-meyer sebastian-meyer deleted the fix-506 branch April 27, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug A non-security related bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants