Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar editor missing confirmation when deleting blocks #3864

Closed
matthias-ronge opened this issue Jul 28, 2020 · 2 comments · Fixed by #4924
Closed

Calendar editor missing confirmation when deleting blocks #3864

matthias-ronge opened this issue Jul 28, 2020 · 2 comments · Fixed by #4924
Labels

Comments

@matthias-ronge
Copy link
Collaborator

matthias-ronge commented Jul 28, 2020

If a block is deleted in the calendar editor, no query appears.

Goal: Question box with message calendar.block.remove.query (Do you want to delete the episode?) should be shown.

@solth
Copy link
Member

solth commented Aug 20, 2020

But removing a calendar block does not actually delete any processes or anything else until the "Create processes" button is clicked, does it? Therefor I would suggest to stick to our established UI interactions where confirm dialogs are only displayed if the user is about to change the persisted data in the database (for example when when deleting a process from the process list).

After all, for the same reason we do not have confirmation dialogs in the metadata editor when for example removing structural elements, because no data is changed on the hard drive until the user clicks the "Save" button.

@matthias-ronge
Copy link
Collaborator Author

matthias-ronge commented Aug 20, 2020

You cannot delete any processes with the calendar editor. These are always issues for which processes should first be created. But a lot of information can be attached to a block, all of which you may have already laboriously entered. In 2.x there was a security question here. That's just what I noticed. If that's a design decision not to check back here, you can just delete the message strings from the properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants