Remove the LDAP on/off switch #4093
Conversation
| # Logins ueber LDAP verwenden | ||
| ldap_use=false | ||
| # Use logins via LDAP | ||
| ldap_use=true |
There was a problem hiding this comment.
Why are you enabling LDAP authentication by default?
There was a problem hiding this comment.
See here:
Procedure proposal:
1. Enable individual users are authenticated against database even when LDAP is on. (#4014) 2. Deactivate the LDAP group for the users supplied with the basic database. (Cf. also #3304) 3. Remove the LDAP on/off switch. (#3336) (The ldap_use parameter in the kitodo_config.properties file should initially be retained so that users can initially remove their LDAP group after a migration. However, the default for this attribute can be set to true for new installations.)
There was a problem hiding this comment.
Than add this as explanation. Without this I would deactivate this again after this pull request is merged!
I hope that your migration way of LDAP usage will be documented somewhere in an official way as issues and pull requests are not a long term documentation.
There was a problem hiding this comment.
As I wrote: You would want to leave the setting unchanged after a migration. It is only about empty new installations, where this can be true in the future (does not have to be. Anyone can set it to false by hand. If someone did that, they should be aware that LDAP does not work.)
Fixes #3336, part of #456
Note: The
ldap_use parameterin thekitodo_config.propertiesfile should initially be retained so that users can initially remove their LDAP group after a migration. However, the default for this attribute can be set to true for new installations.Follow-up pull request to #4092 (immediate diff)