Skip to content

Commit

Permalink
Move getHeaderValueParams & hasHeaderValueOf to util.ts (denoland#5824)
Browse files Browse the repository at this point in the history
  • Loading branch information
marcosc90 committed May 25, 2020
1 parent 131f2a5 commit 20bf04d
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 34 deletions.
18 changes: 1 addition & 17 deletions cli/js/web/body.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import * as blob from "./blob.ts";
import * as encoding from "./text_encoding.ts";
import * as domTypes from "./dom_types.d.ts";
import { ReadableStreamImpl } from "./streams/readable_stream.ts";
import { getHeaderValueParams, hasHeaderValueOf } from "./util.ts";

// only namespace imports work for now, plucking out what we need
const { TextEncoder, TextDecoder } = encoding;
Expand Down Expand Up @@ -90,23 +91,6 @@ function bufferFromStream(stream: ReadableStreamReader): Promise<ArrayBuffer> {
});
}

function getHeaderValueParams(value: string): Map<string, string> {
const params = new Map();
// Forced to do so for some Map constructor param mismatch
value
.split(";")
.slice(1)
.map((s): string[] => s.trim().split("="))
.filter((arr): boolean => arr.length > 1)
.map(([k, v]): [string, string] => [k, v.replace(/^"([^"]*)"$/, "$1")])
.forEach(([k, v]): Map<string, string> => params.set(k, v));
return params;
}

function hasHeaderValueOf(s: string, value: string): boolean {
return new RegExp(`^${value}[\t\s]*;?`).test(s);
}

export const BodyUsedError =
"Failed to execute 'clone' on 'Body': body is already used";

Expand Down
18 changes: 1 addition & 17 deletions cli/js/web/fetch.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,23 +10,7 @@ import { close } from "../ops/resources.ts";
import { Buffer } from "../buffer.ts";
import { fetch as opFetch, FetchResponse } from "../ops/fetch.ts";
import { DomFileImpl } from "./dom_file.ts";

function getHeaderValueParams(value: string): Map<string, string> {
const params = new Map();
// Forced to do so for some Map constructor param mismatch
value
.split(";")
.slice(1)
.map((s): string[] => s.trim().split("="))
.filter((arr): boolean => arr.length > 1)
.map(([k, v]): [string, string] => [k, v.replace(/^"([^"]*)"$/, "$1")])
.forEach(([k, v]): Map<string, string> => params.set(k, v));
return params;
}

function hasHeaderValueOf(s: string, value: string): boolean {
return new RegExp(`^${value}[\t\s]*;?`).test(s);
}
import { getHeaderValueParams, hasHeaderValueOf } from "./util.ts";

class Body
implements domTypes.Body, ReadableStream<Uint8Array>, io.Reader, io.Closer {
Expand Down
19 changes: 19 additions & 0 deletions cli/js/web/util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -189,3 +189,22 @@ export function defineEnumerableProps(
Reflect.defineProperty(Ctor.prototype, prop, { enumerable: true });
}
}

// @internal
export function getHeaderValueParams(value: string): Map<string, string> {
const params = new Map();
// Forced to do so for some Map constructor param mismatch
value
.split(";")
.slice(1)
.map((s): string[] => s.trim().split("="))
.filter((arr): boolean => arr.length > 1)
.map(([k, v]): [string, string] => [k, v.replace(/^"([^"]*)"$/, "$1")])
.forEach(([k, v]): Map<string, string> => params.set(k, v));
return params;
}

// @internal
export function hasHeaderValueOf(s: string, value: string): boolean {
return new RegExp(`^${value}[\t\s]*;?`).test(s);
}

0 comments on commit 20bf04d

Please sign in to comment.