Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move hardcoded links to a config file #4

Closed
tobias-kuendig opened this issue Jan 20, 2017 · 5 comments
Closed

Move hardcoded links to a config file #4

tobias-kuendig opened this issue Jan 20, 2017 · 5 comments

Comments

@tobias-kuendig
Copy link
Contributor

For example:

https://github.com/kitsunekyo/internet-speed-log/blob/master/js/app.js#L153

@phrohdoh
Copy link

phrohdoh commented Jan 21, 2017

Just how should this be used with a local filepath?

I am not exposing my log.json to the web currently.

Is that a requirement?

@tobias-kuendig
Copy link
Contributor Author

tobias-kuendig commented Jan 21, 2017 via email

@claym
Copy link
Contributor

claym commented Jan 21, 2017

Yep, would really appreciate this, so I can git pull without issues :) 👍

@claym
Copy link
Contributor

claym commented Jan 21, 2017

Oh! Might actually be smart to put all the texts into some sort of internationalized file.

Would help as I don't speak German :D

@kitsunekyo
Copy link
Owner

i have now moved pretty much all translatable copy, and configuration values into a config.json file. hope this makes the experience a bit better :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants