-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move hardcoded links to a config file #4
Comments
Just how should this be used with a local filepath? I am not exposing my Is that a requirement? |
With the current setup, yes. Its loaded via ajax request.
Taryn Hill <notifications@github.com> schrieb am Sa., 21. Jan. 2017, 03:27:
… Just how should this be used with a local filepath?
I am not exposing my log.json to the web currently.
Is that a requirement?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIM53STaX5DxITeiSaO9wGD-i-oRVBydks5rUW0LgaJpZM4LpPEk>
.
|
Yep, would really appreciate this, so I can git pull without issues :) 👍 |
Oh! Might actually be smart to put all the texts into some sort of internationalized file. Would help as I don't speak German :D |
i have now moved pretty much all translatable copy, and configuration values into a config.json file. hope this makes the experience a bit better :) |
For example:
https://github.com/kitsunekyo/internet-speed-log/blob/master/js/app.js#L153
The text was updated successfully, but these errors were encountered: