Add json request support in router

[matteocrippa]

I added body access to allow this

[matteocrippa]

@kittinunf is it possible that tests for RequestTest.kt are failing?

Seems:

 timeoutInMillisecond = 15000,
 timeoutReadInMillisecond = 15000

were missing

[kittinunf]

Yes, you are right. I am fixing the test in this PR #334. After that was merged, can you please rebase against new master?

[matteocrippa]

@kittinunf ok, ping me if you notice that I'm missing the merge :)

[kittinunf]

#334 It got merged. Can you rebase? And I will be happy to see this PR get merged 👍 🙏

Ah, sorry. You seem to did that already. Ah you haven't yet.

[kittinunf]

Hmm, do we use this somewhere in the core?

[matteocrippa]

Yep, we need it for tests to manipulate and create a json, dunno why I was not able to get any other access to JSON

[kittinunf]

For tests? Then, perhaps using testCompile is better?

[matteocrippa]

I need that to create a JSON object to test sending that as body

val json = JSONObject()
                         json.put("id", this.value)
                         json.toString()

[kittinunf]

Yes, here right?

  is GetParamsTest -> {
    val json = JSONObject()
    json.put("id", this.value)
    json.toString()

But it is only in the test right? So you can technically just do testCompile 'org.json:json:20170516' so that it doesn't forcefully push dependencies to the users.

[matteocrippa]

Yep, fixed switching it to testCompile

[matteocrippa]

@kittinunf it seems it is now the Jackson test failing

com.github.kittinunf.fuel.FuelJacksonTest > jacksonTestResponseSyncObject FAILED
    com.github.kittinunf.fuel.core.FuelError at FuelJacksonTest.kt:190
        Caused by: com.github.kittinunf.fuel.core.HttpException at FuelJacksonTest.kt:190
com.github.kittinunf.fuel.FuelJacksonTest > jacksonTestResponseSyncObjectError FAILED
    java.lang.AssertionError at FuelJacksonTest.kt:119

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@56cf7ce). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #329   +/-   ##
=========================================
  Coverage          ?   77.21%           
  Complexity        ?      193           
=========================================
  Files             ?       32           
  Lines             ?      904           
  Branches          ?      148           
=========================================
  Hits              ?      698           
  Misses            ?      131           
  Partials          ?       75

Impacted Files	Coverage Δ	Complexity Δ
...tlin/com/github/kittinunf/fuel/util/FuelRouting.kt	100% <100%> (ø)	0 <0> (?)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56cf7ce...d0686bb. Read the comment docs.

[matteocrippa]

Ok, now we should have all the stuff in the right place for testing

[kittinunf]

Awesome, merging this in.