Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix score output bug for FETA and speed up some tests #54

Merged
merged 7 commits into from
Oct 24, 2019
Merged

Fix score output bug for FETA and speed up some tests #54

merged 7 commits into from
Oct 24, 2019

Conversation

prithagupta
Copy link
Collaborator

@prithagupta prithagupta commented Sep 12, 2019 •
edited by kiudee
Loading

Description

I fixed two issues #53 and #51

Motivation and Context

To fix some bugs and increase the speed of the tests #53 and #51

How Has This Been Tested?

Does this close/impact existing issues?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

kiudee
kiudee requested changes Sep 13, 2019
View reviewed changes
Copy link
Owner

@kiudee kiudee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I summarize this pull request there are several distinct changes:

  1. Fix for Bug in predicting scores for feta discrete choice #53 for FETA discrete choice
  2. Sorting imports
  3. Speeding up tests (Speed up Travis-CI builds #51)
  4. Minor changes to dataset parsers
  5. Implement a random baseline for discrete choice
  6. Minor refactorings
  7. Removing several files

How difficult would it be to separate out some of these changes?

csrank/core/fate_linear.py Show resolved Hide resolved
csrank/core/feta_linear.py Show resolved Hide resolved
csrank/discretechoice/feta_discrete_choice.py Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Oct 23, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 555

  • 91 of 206 (44.17%) changed or added relevant lines in 36 files are covered.
  • 13 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-3.2%) to 40.851%
Changes Missing Coverage Covered Lines Changed/Added Lines %
csrank/choicefunction/choice_functions.py 2 3 66.67%
csrank/dataset_reader/discretechoice/letor_listwise_discrete_choice_dataset_reader.py 1 2 50.0%
csrank/learner.py 0 1 0.0%
csrank/util.py 1 2 50.0%
csrank/dataset_reader/expedia_dataset_reader.py 1 3 33.33%
csrank/dataset_reader/letor_listwise_dataset_reader.py 1 3 33.33%
csrank/dataset_reader/letor_ranking_dataset_reader.py 1 3 33.33%
csrank/choicefunction/feta_choice.py 3 6 50.0%
csrank/core/feta_network.py 3 8 37.5%
csrank/discretechoice/baseline.py 13 24 54.17%
Files with Coverage Reduction New Missed Lines %
csrank/dataset_reader/expedia_dataset_reader.py 1 18.66%
csrank/dataset_reader/letor_listwise_dataset_reader.py 1 13.0%
csrank/dataset_reader/letor_ranking_dataset_reader.py 1 13.22%
csrank/dataset_reader/util.py 1 17.7%
csrank/core/feta_network.py 2 62.91%
csrank/discretechoice/feta_discrete_choice.py 2 54.01%
csrank/util.py 5 42.19%
Totals Coverage Status
Change from base Build 527: -3.2%
Covered Lines: 9336
Relevant Lines: 22854
💛 - Coveralls

@kiudee kiudee changed the title Tests Fix score output bug for FETA and speed up some tests Oct 23, 2019
@kiudee kiudee self-requested a review October 24, 2019 14:35
kiudee
kiudee previously approved these changes Oct 24, 2019
View reviewed changes
@prithagupta
Reformated the code
34f9584 
Save State
@prithagupta
Issue #53
3ad9e61 
Renamed the package to choice functions

Added a class for standardizing the features

Removed the bug in predicting the scores using pairs for feta discrete choice

Reformatted the code
@prithagupta
Issue #51 Enhanced pymc3 tests
5efc7f8 
 -Added the ignore folder in gitignore
@prithagupta
Fixed tests and speed up the tests
96465de
@prithagupta
Added verbose for progressbar for choice functions
1800c47 
 - Added another baseline for Object Ranking problem
@prithagupta
Removed bugs in experiments
3adf1d0
@prithagupta
Removed a bug in choice functions
84ee78f
@prithagupta prithagupta merged commit 72daada into master Oct 24, 2019
@prithagupta prithagupta deleted the tests branch October 24, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiudee kiudee kiudee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prithagupta @coveralls @kiudee