Replace imputer usage #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imputer was removed from preprocessing in scikit-learn/scikit-learn#13796. To be compatible with newer scikit-learn versions, we need to stop using it. impute.SimpleImputer seems to be a viable replacement. Do not install scikit-learn thorough conda It is also installed via pip, leading to conflicts (scikit-learn/scikit-learn#15858 in particular). Make csrank compatible with pymc 3.8 There was a backwards-incompatible change in pymc-devs/pymc@521174c
Enable parallel mode for coverage
Pull Request Test Coverage Report for Build 635
💛 - Coveralls |
prithagupta
pushed a commit
that referenced
this pull request
Feb 14, 2020
* Remove usage of Imputer Imputer was removed from preprocessing in scikit-learn/scikit-learn#13796. To be compatible with newer scikit-learn versions, we need to stop using it. impute.SimpleImputer seems to be a viable replacement. Do not install scikit-learn thorough conda It is also installed via pip, leading to conflicts (scikit-learn/scikit-learn#15858 in particular). Make csrank compatible with pymc 3.8 There was a backwards-incompatible change in pymc-devs/pymc@521174c * Install newest version of coverage package during testing Enable parallel mode for coverage * Add back cache Co-authored-by: Timo Kaufmann <timokau@zoho.com>
prithagupta
pushed a commit
that referenced
this pull request
Feb 14, 2020
* Remove usage of Imputer Imputer was removed from preprocessing in scikit-learn/scikit-learn#13796. To be compatible with newer scikit-learn versions, we need to stop using it. impute.SimpleImputer seems to be a viable replacement. Do not install scikit-learn thorough conda It is also installed via pip, leading to conflicts (scikit-learn/scikit-learn#15858 in particular). Make csrank compatible with pymc 3.8 There was a backwards-incompatible change in pymc-devs/pymc@521174c * Install newest version of coverage package during testing Enable parallel mode for coverage * Add back cache Co-authored-by: Timo Kaufmann <timokau@zoho.com>
prithagupta
pushed a commit
that referenced
this pull request
Feb 14, 2020
* Remove usage of Imputer Imputer was removed from preprocessing in scikit-learn/scikit-learn#13796. To be compatible with newer scikit-learn versions, we need to stop using it. impute.SimpleImputer seems to be a viable replacement. Do not install scikit-learn thorough conda It is also installed via pip, leading to conflicts (scikit-learn/scikit-learn#15858 in particular). Make csrank compatible with pymc 3.8 There was a backwards-incompatible change in pymc-devs/pymc@521174c * Install newest version of coverage package during testing Enable parallel mode for coverage * Add back cache Co-authored-by: Timo Kaufmann <timokau@zoho.com>
prithagupta
pushed a commit
that referenced
this pull request
Feb 14, 2020
* Remove usage of Imputer Imputer was removed from preprocessing in scikit-learn/scikit-learn#13796. To be compatible with newer scikit-learn versions, we need to stop using it. impute.SimpleImputer seems to be a viable replacement. Do not install scikit-learn thorough conda It is also installed via pip, leading to conflicts (scikit-learn/scikit-learn#15858 in particular). Make csrank compatible with pymc 3.8 There was a backwards-incompatible change in pymc-devs/pymc@521174c * Install newest version of coverage package during testing Enable parallel mode for coverage * Add back cache Co-authored-by: Timo Kaufmann <timokau@zoho.com>
prithagupta
pushed a commit
that referenced
this pull request
Mar 11, 2020
* Remove usage of Imputer Imputer was removed from preprocessing in scikit-learn/scikit-learn#13796. To be compatible with newer scikit-learn versions, we need to stop using it. impute.SimpleImputer seems to be a viable replacement. Do not install scikit-learn thorough conda It is also installed via pip, leading to conflicts (scikit-learn/scikit-learn#15858 in particular). Make csrank compatible with pymc 3.8 There was a backwards-incompatible change in pymc-devs/pymc@521174c * Install newest version of coverage package during testing Enable parallel mode for coverage * Add back cache Co-authored-by: Timo Kaufmann <timokau@zoho.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a clone of #80.
Imputer was removed from preprocessing in
scikit-learn/scikit-learn#13796. To be
compatible with newer scikit-learn versions, we need to stop using it.
impute.SimpleImputer seems to be a viable replacement.
This caused failures on travis.
Motivation and Context
The latest sklearn caused failures on travis.
How Has This Been Tested?
Ran all tests with sklearn 0.22.
Does this close/impact existing issues?
Impacts #65, where the CI fails because of this.
Types of changes
Checklist: