🚨 Build integration test #1100
Merged
🚨 Build integration test #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes CHANGELOG.md descending PR order
AndreMiras
commented
May 11, 2020
| @@ -36,20 +37,24 @@ | |||
|
|
|||
| **Merged pull requests:** | |||
|
|
|||
| - Android gradle build: fix apk name [\#1025](https://github.com/kivy/buildozer/pull/1025) ([SomberNight](https://github.com/SomberNight)) | |||
There was a problem hiding this comment.
Jus reordered from ascending to descending
AndreMiras
commented
May 11, 2020
| - name: buildozer android debug | ||
| run: | | ||
| touch main.py | ||
| buildozer android debug |
There was a problem hiding this comment.
Adds a 11 minutes overhead, but it's probably worth trying until we have proper unit test coverage 😢
There was a problem hiding this comment.
Oh boy, this is quite of time, but you are right, better this than nothing 👍
opacam
approved these changes
May 16, 2020
| - name: buildozer android debug | ||
| run: | | ||
| touch main.py | ||
| buildozer android debug |
There was a problem hiding this comment.
Oh boy, this is quite of time, but you are right, better this than nothing 👍
|
Yes indeed it's quite some time and most of what we do here is already tested in p4a. But for the lack of having nice unit test coverage we integration test. That will give us confidence that at least the minimum is working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes CHANGELOG.md descending PR order