SafeConfigParser deprecated. #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SafeConfigParser was renamed to ConfigParser in Python 3.2. Use of it in Python 3.7 gives a DeprecationWarning. As Buildozer is not supported at below Python 3.2, simply replaced all mentions. Warning is no longer issued.
AndreMiras
requested changes
Jun 15, 2020
Another instance of SafeConfigParser also converted to ConfigParser. Additionally: * Removed test to see if configparser can be imported - only fails on Python 2. * Re-ordered imports to conform with PEP8. * Only import sys once.
AndreMiras
requested changes
Jun 15, 2020
There was a problem hiding this comment.
Thanks again for the update.
I'd rather focus on that only task and not re-org imports actually 😬
Also commit message says:
Additionally:
* Removed test to see if configparser can be imported - only fails on Python 2.
* Re-ordered imports to conform with PEP8.
* Only import sys once.
I don't see where sys was imported twice. I saw only one import sys instance that you removed.
Also this part Removed test to see if configparser can be imported - only fails on Python 2. I don't see.
Would you mind just addressing the configparser thing and keep the PEP8 cosmetic for another discussion?
If you know how to squash theses changes, then better, otherwise we would do it at merge time (and try to edit the commit message accordingly).
Feel free to ping me on Discord if needed
added 2 commits
June 15, 2020 20:57
This reverts commit 96f5b2e.
Another instance of SafeConfigParser also converted to ConfigParser. Removed test to see if configparser can be imported - only fails on Python 2.
AndreMiras
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SafeConfigParser was renamed to ConfigParser in Python 3.2. Use of it in Python 3.7 gives a DeprecationWarning.
As Buildozer is not supported at below Python 3.2, simply replaced all mentions.
Warning is no longer issued.