Add enable_androidx #1311
Merged
Add enable_androidx #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshirtman
reviewed
Mar 30, 2021
buildozer/default.spec
Outdated
| @@ -162,6 +162,11 @@ fullscreen = 0 | |||
| # (list) Gradle dependencies to add | |||
| #android.gradle_dependencies = | |||
|
|
|||
| # (bool) Enable AndroidX support. Enable when 'android.gradle_dependencies' | |||
| # contains an 'androidx' package, or any package from Kotlin source. | |||
| # android.enable_androidx requires android.api >= 28 | |||
There was a problem hiding this comment.
maybe pep8 is unhappy about the trailing space
Suggested change
| # android.enable_androidx requires android.api >= 28 | |
| # android.enable_androidx requires android.api >= 28 |
There was a problem hiding this comment.
Thank you. It was trailing whitespace.
Closed
|
Shouldn't there be a check for the target API level? It could help users avoid unhelpful errors later in the build process. if int(self.android_api) < 28:
raise BuildozerException("android.enable_androidx requires android.api >= 28.") |
I expect there could be, but the current documentation approach works as shown by the existence of this proposal. The same issue came up with the p4a PR review kivy/python-for-android#2385 (review) where the review comment was "I guess it doesn't really matter". |
tshirtman
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complement to kivy/python-for-android#2385 now merged into p4a develop.