Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed auto build type (ant or gradle) detection #597

Closed
wants to merge 3 commits into from

Conversation

ibobalo
Copy link

@ibobalo ibobalo commented Dec 5, 2017

fixed auto build type (ant or gradle) apk detection. existence of build.gradle is not reliable method, it may be created by some recipes and is not used by python for android.

@inclement
Copy link
Member

Thanks, looks good. I'll try to test and merge at the weekend. If anyone else would like to test it and confirm it works, that would be welcome.

@tito
Copy link
Member

tito commented Dec 15, 2017

I can't merge this PR as it contains other changes than the one PR targetted.
Also, copying multiple times doesn't fix the detection :)

master got a fix about it

@tito tito closed this Dec 15, 2017
@ibobalo
Copy link
Author

ibobalo commented Dec 16, 2017 via email

@ibobalo
Copy link
Author

ibobalo commented Dec 16, 2017

hi
sorry but your method of build type detection is still not reliable.
file build.gradle may exist even for non graddle builds. for example if p4a recipe has own build.gradle like sdl2 recipe has. then you will get copy error tryint to copy apk with graddle name pattern instead ant named apk
also i apologize for multiple commits in one pull request, its a problem of github PRs. it just merges two PRs

@AndreMiras
Copy link
Member

Hi @ibobalo I can tell that after updating to buildozer==0.34 I still get the issue, can you provide another pull request built on top of 0.34 with the reliable method you describe, so I can tell you.

@AndreMiras
Copy link
Member

Ping @ibobalo there's a pull request that may fix it #691 could you review it please?

@ibobalo
Copy link
Author

ibobalo commented Jul 9, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants