Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for bug when logcat value which cannot be decode to utf-8 #856

Merged
merged 1 commit into from
Mar 13, 2019
Merged

Fix for bug when logcat value which cannot be decode to utf-8 #856

merged 1 commit into from
Mar 13, 2019

Conversation

Draqun
Copy link
Contributor

@Draqun Draqun commented Mar 13, 2019

Hi.

I spend 2 days to detect problem with debugging program on my Xiaomi device. So I propose this simple patch which allow replace character which cannot be decode to UTF-8.

Best regards.
Draqun

tshirtman
tshirtman approved these changes Mar 13, 2019
View reviewed changes
Copy link
Member

@tshirtman tshirtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tshirtman tshirtman merged commit 06a964d into kivy:master Mar 13, 2019
@AndreMiras
Copy link
Member

Thanks for the PR 🙏 !
It would have been perfect with a unit test 😅

@Draqun Draqun mentioned this pull request Mar 14, 2019
Closed
@Draqun
Copy link
Contributor Author

Draqun commented Mar 14, 2019

Hi.
Now I don't have time to do it, but in free time in next month I'll try do it.
Best regards.
Draqun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tshirtman tshirtman tshirtman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Draqun @AndreMiras @tshirtman