Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Apache ANT at the same path as the buildozer.spec android.ant_path option #860

Merged
merged 2 commits into from
May 26, 2019

Conversation

robertpro
Copy link
Contributor

ANT installation path was hardcoded so if you changed the installation path, it will download every time you run buildozer android XXX

# Android ANT is missing, downloading
# Downloading http://archive.apache.org/dist/ant/binaries/apache-ant-1.9.4-bin.tar.gz
# Run 'tar xzf apache-ant-1.9.4-bin.tar.gz'
# Cwd /home/roberto/.buildozer/android/platform
# Apache ANT installation done.

I am sorry, I did not found any easy way to test this change since it will download ANT which we don't want that on testing

@AndreMiras
Copy link
Member

Thanks that sounds relevant.
Thanks for mentioning tests, by the way, yes there's probably a way to test it with unittest.mock if you mock.patch both buildozer.download() and buildozer.file_extract() and verify it was called with the expected params.

Anyway the PR looks fine, but I still want to give it a try before merging. In the meantime if you want to give unit tests a try, feel free 😄

@robertpro
Copy link
Contributor Author

Thanks @AndreMiras, I learned something new :) please review!

@inclement inclement merged commit 81b6ac5 into kivy:master May 26, 2019
@inclement
Copy link
Member

Thanks @robertpro, sorry for the delay merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants