Rename final apk with arch in the name #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshirtman
previously approved these changes
Sep 11, 2019
AndreMiras
previously approved these changes
Sep 11, 2019
buildozer/targets/android.py
Outdated
| @@ -1144,6 +1146,11 @@ def build_package(self): | |||
| apk_dir = join(dist_dir, "bin") | |||
| apk_dest = apk | |||
|
|
|||
| packagename = config.get('app', 'package.name') | |||
| apk_dest = u'{packagename}-{version}-{arch}-{mode}.apk'.format( | |||
There was a problem hiding this comment.
That line apk_dest = apk above should then be removed, since we override it and don't use it anymore
buildozer/targets/android.py
Outdated
| apk_dest = u'{packagename}-{version}-{mode}.apk'.format( | ||
| packagename=packagename, mode=mode, version=version) | ||
|
|
||
| apk_dest = u'{packagename}-{version}-{arch}-{mode}.apk'.format( |
There was a problem hiding this comment.
We could move it outside the if/else and have that part made only once since we're doing exactly the same inside and outside the if/else
AndreMiras
reviewed
Sep 11, 2019
buildozer/targets/android.py
Outdated
| @@ -1142,7 +1139,11 @@ def build_package(self): | |||
| version=version, | |||
| mode=mode) | |||
| apk_dir = join(dist_dir, "bin") | |||
| apk_dest = apk | |||
| packagename = config.get('app', 'package.name') | |||
There was a problem hiding this comment.
Theoretically this guy could also get out the if/else 😬 since we have it in both here and line 1126.
So I would suggest to remove it from both and put it just before the if is_gradle_build: block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If i do 2 build with the same buildozer spec, but 2 profiles with different arch (or 2 buildozer spec), i don't want the final apk to be overwritten. So now the final apk name contains the arch:
For example:
connectage-0.4.0.23-arm64-v8a-release.apkconnectage-0.4.0.23-armeabi-v7a-release.apk