Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zbarlight recipe to 3.0, refactor #805

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

Cheaterman
Copy link
Contributor

Probably should merge #804 first, although I'm not 100% certain - what's for sure is that I didn't try this recipe without refactored biglink, since it seems to me like it was required last time I worked on this (sooo much time ago already haha, it's more than time to PR everything!)

@misl6
Copy link
Member

misl6 commented Jun 12, 2023

Hi @Cheaterman,

Can you please rebase on top of the master branch which now includes #804, so the CI can run again?

@Cheaterman
Copy link
Contributor Author

Done, thanks for the heads up 👍

Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have the chance to test it on runtime, but considering that the recipe was broken, it's still an improvement.

The code, LGTM. Thank you!

@misl6 misl6 merged commit 5221358 into kivy:master Jun 13, 2023
@Cheaterman Cheaterman deleted the update_zbarlight branch June 14, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants