Fix scrolling in TabbedPanel #4559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Better this way, as it throws errors if it scrolls by default (and will break api for versions older than this patch) |
| def switch_to(self, header): | ||
| '''Switch to a specific panel header. | ||
| def switch_to(self, header, do_scroll=False): | ||
| '''Switch to a specific panel header. If used with `do_scroll=True`, it scrolls to the header's tab too. |
pep8 fixed
| '''Switch to a specific panel header. | ||
| def switch_to(self, header, do_scroll=False): | ||
| '''Switch to a specific panel header. If used with | ||
| `do_scroll=True`, it scrolls to the header's tab too. |
There was a problem hiding this comment.
A versionchanged tag could be added for the new arg.
|
Ah, I can't edit after merge. O.o |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
switch_to(tab, do_scroll=False)is the behavior until this patch. This introducesdo_scrollkeyword, which if set to True(by default), scrolls the tab list to the header of the tab TabbedPanel switches to.