Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize version #4949

Merged
merged 5 commits into from
Jan 27, 2017
Merged

Normalize version #4949

merged 5 commits into from
Jan 27, 2017

Conversation

KeyWeeUsr
Copy link
Contributor

ref #4861

Standardized format for version in X.Y.Z[.dev0+hash] shape. Can be turned off for a release with env variable KIVY_RELEASE.

There were necessary changes in parse_version, otherwise it won't accept such a version. It might break the previous kivy.require() in some cases.

Hopefully there won't be much appveyor script can break in this and as discussed before, since this change there'll be necessary to force install each master version, because there'll be no way how to compare the versions because of the hash (unless MICRO changes):

from packaging.version import parse
parse('1.9.2-dev0.24012017.e4d8cb9c') < parse('1.9.2-dev0.25012017.a9d5d756')
# True
parse('1.9.2-dev0+e4d8cb9c') < parse('1.9.2-dev0+a9d5d756')
# False

@KeyWeeUsr KeyWeeUsr merged commit da56a25 into kivy:master Jan 27, 2017
KeyWeeUsr added a commit that referenced this pull request Mar 1, 2017
otherwise https://kivy.org/docs/api-kivy.version.html empty 'NO DOCUMENTATION (module ...)' file is created'. See #4949 for details.
@KeyWeeUsr KeyWeeUsr deleted the normalize_version branch March 9, 2017 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant