-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[base/properties]Cache values of AliasProperty where possible #6055
[base/properties]Cache values of AliasProperty where possible #6055
Conversation
For case in kivy/uix/screenmanager.py I think we need another method in |
@tshirtman @KeyWeeUsr Can you take a look at this pull request? |
@tito What do you think about adding a |
@pythonic64 What rebase would do in your mind? Anyway, just another couple of changes here and it would be ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just remove the couple of caching discussed in command and we're good to merge!
Request should be good to merge now. I will investigate |
…`bbox` to `Scatter` properties: `right`, `top`, `center_x`, `center_y`.
716a8bd
to
2ca1dac
Compare
Please let us know when you think it's in a good state to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to have implemented @tito 's changes so it looks ok.
Builds upon #5856 and aims to increase widgets performance by caching values of
AliasProperty
where possible.