Add padding between AnchorLayout and children #1981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaineacsu
changed the title
| @@ -83,11 +83,11 @@ def do_layout(self, *largs): | |||
| x, y = _x, _y | |||
| w, h = c.size | |||
| if c.size_hint[0]: | |||
| w = c.size_hint[0] * width | |||
| w = (c.size_hint[0] * width) - (2 * padding) | |||
There was a problem hiding this comment.
padding is a VariableListProperty so one can have padding[0] for the left be different from padding[2] for the right side. You need to account for that.
|
@akshayaurora Padding is a NumericProperty in the case of AnchorLayout. |
|
@Voen I see it wasn't updated with the rest of the layouts. In order to make it consistent with the rest of the layouts we should be using a VariablelistProeprty for padding. @mihaineacsu could you please look into changing |
|
@akshayaurora sure, will do! |
Calculate horizontal and vertical padding correctly
akshayaurora
added a commit
that referenced
this pull request
Mar 20, 2014
…issue Add padding between AnchorLayout and children
|
@mihaineacsu thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1980: if size_hint is not None, specified padding should be deducted from children's size.