Fix dismiss in ActionGroup #4441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeyWeeUsr
force-pushed
the
actiongroup_close
branch
from
7d7b57e
to
275cb51
Compare
|
Now it should fix even those badly displayed properties and stuff in docs. |
|
@KeyWeeUsr thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there's no desire to actually change group name after selecting an item there, then it's good to go. Maybe a dirty fix, but does the work. Still don't know what exactly prevents DropDown from closing. Maybe because it's inherited and put in another widget, therefore if I click on the button some function from DropDown isn't triggered?
I think using
return Truemay be a problem here, because it doesn't even get to the autodismiss part(which is in dropdown as the last written), so... I moved it to the top basically.Try
on_release, forBtn3, works good.Fix #1906