Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite ActionGroup from Spinner to Button+DropDown #5339

Merged
merged 1 commit into from
Aug 24, 2017

Conversation

KeyWeeUsr
Copy link
Contributor

Compared to the previous behavior the current implementation doesn't cripple the graphics anymore i.e. when you click on a Button in the DropDown, you can actually see the smooth changes of the color e.g. like when you click on_press in a pure Button widget.

Then, using Spinner in the first place makes no sense to me at all because the only thing used from there is the actual DropDown and an overhead + bugs it brought when trying to set is_open in a weird way.

Also, sometimes when opening one group and then another (click on Group 1, then on Group 2), the DropDown could stay opened. And sometimes it disappeared correctly.

Closes #5337, #5338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant