Rewrite ActionGroup from Spinner to Button+DropDown #5339
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compared to the previous behavior the current implementation doesn't cripple the graphics anymore i.e. when you click on a
Button
in theDropDown
, you can actually see the smooth changes of the color e.g. like when you clickon_press
in a pureButton
widget.Then, using
Spinner
in the first place makes no sense to me at all because the only thing used from there is the actualDropDown
and an overhead + bugs it brought when trying to setis_open
in a weird way.Also, sometimes when opening one group and then another (click on
Group 1
, then onGroup 2
), theDropDown
could stay opened. And sometimes it disappeared correctly.Closes #5337, #5338