Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raspbian stretch egl library fix #5362

Merged
merged 5 commits into from
Sep 6, 2017
Merged

Raspbian stretch egl library fix #5362

merged 5 commits into from
Sep 6, 2017

Conversation

rasmuspeders1
Copy link
Contributor

Proposed fix for replacing the names of libraries EGL and GLESv2 to brcmEGL and brcmGLESv2 which seems like the correct way to get kivy to use the closed source broadcom ELG GLESv2 libs on raspian stretch.

Only replaces the names if platform is rpi and linux dist is debian 9.1 or newer.

Proposed fix inspired from this issue report: #5341

@dbgasaway
Copy link

Is release 9.1 the correct release to compare to? These libraries are actually available under the new names in 8.0, at least on my pi, and it's possible someone with 9.0 could have these problems as well (if that's even possible to have as a version on a pi).

Also, the current code (in my understanding) checks if it's an rpi by checking for the existence of the file /opt/vc/include/bcm_host.h on line 129 at https://github.com/rasmuspeders1/kivy/blob/6043834d4532b67cab6e01783883467f0db96b99/setup.py#L129. Maybe the best solution for detecting the new library names, using a similar technique, would be to check for the libbrcmGLESv2 and libbrcmEGL files in /opt/vc/lib/? Especially considering that it's already manually adding the /opt/vc/lib/ include directory, and it avoids checking a high-level feature like a Debian release version.

@rasmuspeders1
Copy link
Contributor Author

I agree @dbgasaway. The idea withe simply checking the distribution and version was to affect only this and newer distros.
I like your idea with checking if libbrcmEGL and libbrcmGLESv2 exists better. This could potentially solve the issue on different and older distros as well, provided they follow the same naming convention as Raspbian. And it should be at least as safe as my original proposed fix.

I will push a change with this different solution to the pull request.

@rasmuspeders1
Copy link
Contributor Author

The pull request is updated. It has been tested successfully on a rpi with rasbian stretch.

@tito
Copy link
Member

tito commented Sep 6, 2017

Looks good, thanks you!

@tito tito closed this Sep 6, 2017
@tito tito reopened this Sep 6, 2017
@tito tito merged commit 78a4206 into kivy:master Sep 6, 2017
@rasmuspeders1 rasmuspeders1 deleted the raspbian-stretch-EGL-library-fix branch October 11, 2017 11:38
rnixx added a commit to rnixx/kivy that referenced this pull request Sep 17, 2018
rnixx added a commit to rnixx/kivy that referenced this pull request Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants