-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
audio_sdl2: Update for mixer v2.0.2 support #5459
Conversation
Flags MIX_INIT_MODPLUG was removed, and MIX_INIT_FLUIDSYNTH was renamed to MIX_INIT_MID.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the issue regarding the sdl2 error ^_^
This was tested on:
OS X: 10.13
Python: 3.6
Xcode: 9.1
Brew installation of sdl packages
Thanks! |
Can you please suggest what needs to be done in order to install "kivy"? I get the following error when I run "pip install kivy". /private/var/folders/1v/fsz767yj41q7hx2pd6kmzpfr0000gn/T/pip-build-Gtlg9Q/kivy/kivy/core/audio/audio_sdl2.c:1742:63: error: use of undeclared identifier 'MIX_INIT_MODPLUG'; did you mean 'MIX_INIT_MOD'? |
@sp- Please use the development version of kivy which indicated on the kivy website MacOS installation. pip install http://github.com/kivy/kivy/archive/master.zip |
@lfasmpao Big thanks! Wasn't able to install (last installation step) using 'pip install kivy' form within my virtualenv. 'pip install http://github.com/kivy/kivy/archive/master.zip' worked for me as well. System specs:
|
I confirm it fixes it also on Ubuntu 18.04. See log extract below:
Installing from that commit hash fixed it:
|
Quick fix for #5457. The
MIX_INIT_*
flags no longer represent specific libraries, but instead "abstract format types" see here. It appears like the proper way to query for the exact library support is has_music, but that raises many questions.This should in theory work with old and new versions, but I looked very quickly at the upstream changes... there could be other problems left to fix