[input]Fix FileNotFoundError when sys path doesn't exist

[thecodenomad]

This is intended to fix #5534

You get a FileNotFoundError when trying to access '/sys/class/input/event/device/capabilities/abs' when the full path doesn't exist.

This may be an input device, but capabilities aren't listed so the fix just defaults "0".

[welcome]

Thanks for opening your first pull request here! 💖 Please check out our contributing guidelines.

[KeyWeeUsr]

Ref e18cd35#diff-2eeaed663bd0d25b7e608891384b7298 try to use OSError instead.

Also, shouldn't you instead just return [] from the exception? What's the point of going through the computation and return [False]?

[thecodenomad]

All good points ;) Updated the fix based on comments (squashed commits as well, sorry about that).

[tito]

Thanks you!

[welcome]

Congrats on merging your first pull request! 🎉🎉🎉

[AndreMiras]

Is this not throwing a IOError (python2) or FileNotFoundError (python3) instead?

[KeyWeeUsr]

I think it returns OSError for Windows, but I'm not sure if OSError is the parent or IOError, sooo... test or check with cpython source I'd say :) It should handle FNF in either case for py3 iirc.

Edit: I'd add it, so that it's a tuple with IO and OS errors caught.

[AndreMiras]

Thanks! Yes at the same time I'm getting confused by other commits d80528b which seems to tackle it, but I didn't investigate why I don't see it in the code base.
In the meantime, this is what I have on Linux (python2 and python3):

[andre:/tmp] 2 $ python2 -c "open('/does_not_exist/')"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
IOError: [Errno 2] No such file or directory: '/does_not_exist/'
[andre:/tmp] 1 $ python3 -c "open('/does_not_exist/')"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
FileNotFoundError: [Errno 2] No such file or directory: '/does_not_exist/'
[andre:/tmp] 1 $ 

[KeyWeeUsr]

@AndreMiras This resolves FNF → https://github.com/python/cpython/blob/621cebe81b1e6c8de10425955bf532d31ee4df42/Objects/exceptions.c#L1256 (OSError), for the rest just append IOError if it still brags :)

[AndreMiras]

Oh didn't know about that thingy. Thanks