Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add textedit event #5597

Merged
merged 5 commits into from
May 8, 2018
Merged

Add textedit event #5597

merged 5 commits into from
May 8, 2018

Conversation

Adachinski
Copy link
Contributor

This makes it possible to dispatch the 'textedit' event added in #5109 by WindowSDL and sub class.

*Sample code to display the text being edited on the label
https://github.com/Adachinski/kivy_textedit_sample

@KeyWeeUsr
Copy link
Contributor

@Adachinski Hi, thanks for the PR. I wonder if you could simplify the example you provide in the separate repository into a single file that shows the feature? I think it'd be a nice addition to the examples section.

@KeyWeeUsr KeyWeeUsr self-assigned this Feb 6, 2018
@KeyWeeUsr KeyWeeUsr added Component: core-providers kivy/core Type: Feature Issue is a feature request labels Feb 6, 2018
@Adachinski
Copy link
Contributor Author

@KeyWeeUsr
Hi.
I have committed a sample simplified to single file like any other.
(Multi language font is set by the user, necessary for character display)

Thanks.

@okajun35
Copy link

okajun35 commented May 7, 2018

@KeyWeeUsr  I would like some comments on this pull request.
This function is to use the Kivy is required in Japan.

@KeyWeeUsr KeyWeeUsr merged commit 87897c4 into kivy:master May 8, 2018
@KeyWeeUsr
Copy link
Contributor

@Adachinski @okajun35 I apologize for the delay, the PR seems OK to me.

@okajun35
Copy link

okajun35 commented May 9, 2018

@KeyWeeUsr Thanks for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: core-providers kivy/core Type: Feature Issue is a feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants