[core/camera]Set android camera to autofocus #5940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreMiras
previously approved these changes
Sep 20, 2018
There was a problem hiding this comment.
LGTM, I've also enabled it in https://github.com/kivy-garden/garden.zbarcam/blob/20171220/zbarcam/zbarcam.py#L72
|
I also changed the fragment shader to rotate the texture for android devices. |
|
Except the pep8, looks good! |
tito
approved these changes
Oct 4, 2018
matham
changed the title
AndreMiras
added a commit
to kivy-garden/zbarcam
that referenced
this pull request
Sep 4, 2019
AndreMiras
added a commit
to kivy-garden/zbarcam
that referenced
this pull request
Sep 4, 2019
AndreMiras
added a commit
to kivy-garden/zbarcam
that referenced
this pull request
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the Camera widget on Android to autofocus. This avoids the blurry images that appear when using this widget.